linux-kernel - Re: [PATCH net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161249160678.1910.11108214897689431024.git-patchwork-notify@kernel.org>
Date:   Fri, 05 Feb 2021 02:20:06 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     David Howells <dhowells@...hat.com>
Cc:     netdev@...r.kernel.org,
        syzbot+174de899852504e4a74a@...kaller.appspotmail.com,
        syzbot+3d1c772efafd3c38d007@...kaller.appspotmail.com,
        hdanton@...a.com, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 03 Feb 2021 08:47:56 +0000 you wrote:
> At the end of rxrpc_release_call(), rxrpc_cleanup_ring() is called to clear
> the Rx/Tx skbuff ring, but this doesn't lock the ring whilst it's accessing
> it.  Unfortunately, rxrpc_resend() might be trying to retransmit a packet
> concurrently with this - and whilst it does lock the ring, this isn't
> protection against rxrpc_cleanup_call().
> 
> Fix this by removing the call to rxrpc_cleanup_ring() from
> rxrpc_release_call().  rxrpc_cleanup_ring() will be called again anyway
> from rxrpc_cleanup_call().  The earlier call is just an optimisation to
> recycle skbuffs more quickly.
> 
> [...]

Here is the summary with links:
  - [net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call
    https://git.kernel.org/netdev/net/c/7b5eab57cac4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html