linux-kernel - Re: [PATCH v2] drm/qxl: do not run release if qxl failed to init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <BCB24CD0-FD0F-4202-AD93-02A7EDC229C9@gmail.com>
Date:   Fri, 5 Feb 2021 10:31:58 -0500
From:   Tong Zhang <ztong0001@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>
Cc:     Dave Airlie <airlied@...hat.com>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "open list:DRM DRIVER FOR QXL VIRTUAL GPU" 
        <virtualization@...ts.linux-foundation.org>,
        "open list:DRM DRIVER FOR QXL VIRTUAL GPU" 
        <spice-devel@...ts.freedesktop.org>,
        dri-devel@...ts.freedesktop.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/qxl: do not run release if qxl failed to init

On Feb 5, 2021, at 2:43 AM, Gerd Hoffmann <kraxel@...hat.com> wrote:
> 
> On Thu, Feb 04, 2021 at 11:30:50AM -0500, Tong Zhang wrote:
>> if qxl_device_init() fail, drm device will not be registered,
>> in this case, do not run qxl_drm_release()
> 
> How do you trigger this?
> 

This can be triggered by changing the QXL VGA rom magic value.

In the QEMU source code ./hw/display/qxl.c
or change the QXL_ROM_MAGIC in spice header file

- Tong

> take care,
>  Gerd
>