linux-kernel - Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YB1QCHGUdDptkP0M@ArchLinux>
Date:   Fri, 5 Feb 2021 19:32:48 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     richard@....at, vigneshr@...com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH] drivers: mtd: Better word replace a not so good word in
 the file mtd_blkdevs.c

On 14:57 Fri 05 Feb 2021, Miquel Raynal wrote:
>Hi Bhaskar,
>
>Bhaskar Chowdhury <unixbhaskar@...il.com> wrote on Fri, 5 Feb 2021
>19:06:39 +0530:
>
>> On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>> >Hi Bhaskar,
>> >
>> >Bhaskar Chowdhury <unixbhaskar@...il.com> wrote on Fri,  5 Feb 2021
>> >18:11:51 +0530:
>> >
>> >> s/fucking/invite/
>> >>
>> >>
>> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> >> ---
>> >>  drivers/mtd/mtd_blkdevs.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
>> >> index fb8e12d590a1..756a0995e474 100644
>> >> --- a/drivers/mtd/mtd_blkdevs.c
>> >> +++ b/drivers/mtd/mtd_blkdevs.c
>> >> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t
>> r)
>> >>  	int ret;
>> >>
>> >>  	/* Register the notifier if/when the first device type is
>> >> -	   registered, to prevent the link/init ordering from fucking
>> >> +	   registered, to prevent the link/init ordering from invite
>> >>  	   us over. */
>> >
>> >invite us over?
>> >
>> >I'm not a native English speaker but this does not bring any value to
>> >my ears. Worse, I don't even get the point. Better rewrite the comment
>> >entirely than just swapping "fucking" with a random word, no?
>> >
>> Got your point , and I do understand "fuck" and "fucking" is so strong word
>> that it is really difficult to replace with something else.
>>
>> But..but you suggestion to rewrite the comments sounds good Miquel ...wish I
>> could have that much time in hand to replace every sentence having that word
>> ...all the patched sent with that word replaces...please step forward and
>>  make
>> and send patches .
>>
>> Today I sent 10 patches replacing that word(weather that make sense or not)
>> you can see those in the ML ...please pick up as you wish and send patches.
>
>There are currently 21 uses of "fuck[ing]". It's not a mountain to
>climb. Nor a race.
>
✔ ~/git-linux/linux [master|✔]
19:28 $ search fuck | wc -l
15

>> I was simply replacing the word ..never bother about the meaning it
>> conveys..doesn't matter really.
>
>Are you kidding? What is the purpose of a comment if no one understands
>it after a blind change?
>
No I am not . But the sentences contains that word hardly have more meaning. But as you already said rewriting those comment would be a good idea...can you take up some of those??

>>
>> so...
>>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)