linux-kernel - Re: [PATCH] xfs: fix unused variable build warning in xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 4 Feb 2021 19:30:30 -0800
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     John Hubbard <jhubbard@...dia.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>, linux-xfs@...r.kernel.org,
        Linux Next <linux-next@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Brian Foster <bfoster@...hat.com>,
        Christoph Hellwig <hch@....de>,
        Allison Henderson <allison.henderson@...cle.com>
Subject: Re: [PATCH] xfs: fix unused variable build warning in xfs_log.c

On Thu, Feb 04, 2021 at 07:18:14PM -0800, John Hubbard wrote:
> Delete the unused "log" variable in xfs_log_cover().
> 
> Fixes: 303591a0a9473 ("xfs: cover the log during log quiesce")
> Cc: Brian Foster <bfoster@...hat.com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Darrick J. Wong <djwong@...nel.org>
> Cc: Allison Henderson <allison.henderson@...cle.com>
> Signed-off-by: John Hubbard <jhubbard@...dia.com>
> ---
> Hi,
> 
> I just ran into this on today's linux-next, so here you go!

Thanks for the tipoff, I just realized with horror that I got the git
push wrong and never actually updated xfs-linux.git#for-next.  This (and
all the other gcc warnings) are fixed in "xfs-for-next" which ... is not
for-next.

Sigh.....  so much for trying to get things in for testing. :(

--D

> 
> thanks,
> John Hubbard
> NVIDIA
> 
>  fs/xfs/xfs_log.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index 58699881c100..5a9cca3f7cbf 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -1108,7 +1108,6 @@ static int
>  xfs_log_cover(
>  	struct xfs_mount	*mp)
>  {
> -	struct xlog		*log = mp->m_log;
>  	int			error = 0;
>  	bool			need_covered;
>  
> 
> base-commit: 0e2c50f40b7ffb73a039157f7c38495c6d99e86f
> -- 
> 2.30.0
>