linux-kernel - Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE1WUT7BHwyL600Zx_3JrG4CGUgCTdufr8Hyy0ObYALqHO_OoQ@mail.gmail.com>
Date:   Thu, 4 Feb 2021 21:00:14 -0800
From:   Amy Parker <enbyamy@...il.com>
To:     Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
Cc:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

On Thu, Feb 4, 2021 at 8:57 PM Chaitanya Kulkarni
<Chaitanya.Kulkarni@....com> wrote:
>
> On 2/4/21 20:55, Amy Parker wrote:
> > Many single-line statements have unnecessary braces, and some statement pairs have mismatched braces. This is a clear violation of the kernel style guide, which mandates that single line statements have no braces and that pairs with at least one multi-line block maintain their braces.
> >
> > This patch fixes these style violations. Single-line statements that have braces have had their braces stripped. Pair single-line statements have been formatted per the style guide. Pair mixed-line statements have had their braces updated to conform.
> >
> > Signed-off-by: Amy Parker <enbyamy@...il.com>
> Commit message is too long. Follow the style present in the tree.

Are you referring to the per-line length? That was supposed to have
been broken up, my apologies. Or is it the overall length that is the
issue?

   -Amy IP