linux-kernel - Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210205002811.GV4035784@sasha-vm>
Date:   Thu, 4 Feb 2021 19:28:11 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Anthony Iliopoulos <ailiop@...e.com>, dm-devel@...hat.com,
        linux-raid@...r.kernel.org, Mike Snitzer <snitzer@...hat.com>
Subject: Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select
 CRYPTO_SKCIPHER

On Tue, Jan 19, 2021 at 09:47:31PM -0800, Eric Biggers wrote:
>On Tue, Jan 19, 2021 at 08:26:40PM -0500, Sasha Levin wrote:
>> From: Anthony Iliopoulos <ailiop@...e.com>
>>
>> [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]
>>
>> The integrity target relies on skcipher for encryption/decryption, but
>> certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
>> compilation errors due to unresolved symbols. Explicitly select
>> CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
>> on it.
>>
>> Signed-off-by: Anthony Iliopoulos <ailiop@...e.com>
>> Signed-off-by: Mike Snitzer <snitzer@...hat.com>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  drivers/md/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
>> index aa98953f4462e..7dd6e98257c72 100644
>> --- a/drivers/md/Kconfig
>> +++ b/drivers/md/Kconfig
>> @@ -565,6 +565,7 @@ config DM_INTEGRITY
>>  	select BLK_DEV_INTEGRITY
>>  	select DM_BUFIO
>>  	select CRYPTO
>> +	select CRYPTO_SKCIPHER
>>  	select ASYNC_XOR
>>  	---help---
>>  	  This device-mapper target emulates a block device that has
>
>CRYPTO_SKCIPHER doesn't exist in 5.4 and earlier because it was renamed from
>CRYPTO_BLKCIPHER in 5.5.  If this patch is really important enough to backport,
>CRYPTO_SKCIPHER will need to be changed to CRYPTO_BLKCIPHER.

I'll just drop it, thanks!

-- 
Thanks,
Sasha