linux-kernel - Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210205004050.GA3319@p4>
Date:   Fri, 5 Feb 2021 00:40:54 +0000
From:   Giancarlo Ferrari <giancarlo.ferrari89@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org,
        penberg@...nel.org, geert@...ux-m68k.org, rppt@...nel.org,
        akpm@...ux-foundation.org, linux-arm-kernel@...ts.infradead.org,
        giancarlo.ferrari@...ia.com
Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated

Russell,

On Fri, Feb 05, 2021 at 12:18:33AM +0000, Russell King - ARM Linux admin wrote:
> On Thu, Feb 04, 2021 at 11:48:42PM +0000, Giancarlo Ferrari wrote:
> > Can I ask about having it integrated ?
> 
> Thanks for testing. Are you willing for me to add:
> 
> Tested-by: Giancarlo Ferrari <giancarlo.ferrari89@...il.com>
> 
> to the commit log?
> 

Sure.

I have a question regarding the patch. I saw that the structure start at
the end of the relocation code:

data = reboot_code_buffer + relocate_new_kernel_size;

which means it overlap with the global symbol relocate_new_kernel_size.
I think is minor comment as the variable is only used in the fncpy()
then thrown away. Something like:

data = reboot_code_buffer + relocate_new_kernel_size + sizeof(long);

and accordingly in the instruction (arch/arm/kernel/relocate_kernel.S):

adr	r7, relocate_new_kernel_end

> I can move it into the fixes branch which I want to send to Linus by
> Saturday at the very latest.
> 

I am not used with all the merging process. However it sounds great !

> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Thanks in advance,


GF