linux-kernel - Re: [PATCH] nios2: fixed broken sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210205083850.d5tcnyawnxismwfn@wittgenstein>
Date:   Fri, 5 Feb 2021 09:38:50 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Andreas Oetken <ennoerlangen@...glemail.com>
Cc:     Ley Foon Tan <ley.foon.tan@...el.com>,
        linux-kernel@...r.kernel.org,
        Andreas Oetken <ennoerlangen@...il.com>,
        Andreas Oetken <andreas.oetken@...mens.com>
Subject: Re: [PATCH] nios2: fixed broken sys_clone syscall

On Fri, Feb 05, 2021 at 09:23:38AM +0100, Andreas Oetken wrote:
> From: Andreas Oetken <andreas.oetken@...mens.com>
> 
> The tls pointer must be pushed on the stack prior to calling nios2_clone
> as it is the 5th function argument. Prior handling of the tls pointer was
> done inside former called function copy_thread_tls using the r8 register
> from the current_pt_regs directly. This was a bad design and resulted in
> the current bug introduced in 04bd52fb.
> 
> Fixes: 04bd52fb ("nios2: enable HAVE_COPY_THREAD_TLS, switch to kernel_clone_args")
> Signed-off-by: Andreas Oetken <andreas.oetken@...mens.com>
> ---

Thanks for catching this!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>