linux-kernel - Re: [PATCH v14 6/8] mm: hugetlb: introduce nr_free_vmemmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <318aa24d-86a7-0a18-c4df-80aa857e5388@huawei.com>
Date:   Fri, 5 Feb 2021 17:12:45 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Oscar Salvador <osalvador@...e.de>
CC:     Muchun Song <songmuchun@...edance.com>,
        <duanxiongchun@...edance.com>, <linux-doc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        <linux-fsdevel@...r.kernel.org>, <corbet@....net>,
        <mike.kravetz@...cle.com>, <tglx@...utronix.de>,
        <mingo@...hat.com>, <bp@...en8.de>, <x86@...nel.org>,
        <hpa@...or.com>, <dave.hansen@...ux.intel.com>, <luto@...nel.org>,
        <peterz@...radead.org>, <viro@...iv.linux.org.uk>,
        <akpm@...ux-foundation.org>, <paulmck@...nel.org>,
        <mchehab+huawei@...nel.org>, <pawan.kumar.gupta@...ux.intel.com>,
        <rdunlap@...radead.org>, <oneukum@...e.com>,
        <anshuman.khandual@....com>, <jroedel@...e.de>,
        <almasrymina@...gle.com>, <rientjes@...gle.com>,
        <willy@...radead.org>, <mhocko@...e.com>,
        <song.bao.hua@...ilicon.com>, <david@...hat.com>,
        <naoya.horiguchi@....com>
Subject: Re: [PATCH v14 6/8] mm: hugetlb: introduce nr_free_vmemmap_pages in
 the struct hstate

On 2021/2/5 16:56, Oscar Salvador wrote:
> On Fri, Feb 05, 2021 at 04:39:26PM +0800, Miaohe Lin wrote:
>> Hi:
>> On 2021/2/5 16:22, Oscar Salvador wrote:
>>> On Fri, Feb 05, 2021 at 03:29:43PM +0800, Miaohe Lin wrote:
>>>>> +	if (likely(vmemmap_pages > RESERVE_VMEMMAP_NR))
>>>>> +		h->nr_free_vmemmap_pages = vmemmap_pages - RESERVE_VMEMMAP_NR;
>>>>
>>>> Not a problem. Should we set h->nr_free_vmemmap_pages to 0 in 'else' case explicitly ?
>>>
>>> No, hstate fields are already zeroed.
>>
>> I know hstate fields are already zeroed. What I mean is should we set nr_free_vmemmap_pages
>> to 0 _explicitly_ like nr_huge_pages and free_huge_pages in hugetlb_add_hstate() ?
>> But this is really trival.
> 
> We do not anny more [1]
> 
> [1] https://patchwork.kernel.org/project/linux-mm/patch/20201119112141.6452-1-osalvador@suse.de/
> 
> 

Oh, I see. I thought we do it deliberately. Many thanks for your patient answer. :)