linux-kernel - AW: [PATCH v2 4/4] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 10:00:35 +0000
From:   Sven Schuchmann <schuchmann@...leissheimer.de>
To:     Pavel Machek <pavel@....cz>
CC:     Dan Murphy <dmurphy@...com>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH v2 4/4] leds: lp50xx: add setting of default intensity
 from DT

Hello Pavel,
> 
> > Signed-off-by: Sven Schuchmann <schuchmann@...leissheimer.de>
> 
> Check your email headers, empty To: is strange.
> 
> > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > index 79bc071c31fb..e8aa36c7e963 100644
> > --- a/drivers/leds/leds-lp50xx.c
> > +++ b/drivers/leds/leds-lp50xx.c
> > @@ -504,6 +504,24 @@ static int lp50xx_probe_dt(struct lp50xx *priv)
> >  			num_colors++;
> >  		}
> >
> > +		if (fwnode_property_count_u32(child, "default-intensity")
> > +			== num_colors) {
> > +
> > +			int j, def_int[LP50XX_LEDS_PER_MODULE];
> 
> No need for empty line?

Using "git send-email", maybe I am doing something wrong here, will check.


> > +			ret = fwnode_property_read_u32_array(child,
> > +				"default-intensity", def_int, num_colors);
> > +			if (ret) {
> > +				dev_err(&priv->client->dev,
> > +					"Cannot read default-intensity: %d\n",
> > +					ret);
> > +				goto child_out;
> > +			}
> 
> Just ignore such error?

Yes, I will ignore in the next version

Best Regards,

   Sven