linux-kernel - Re: [PATCH] ARM: configs: at91: enable drivers for sam9x60

Open Source and information security mailing list archives

Message-ID: <225500e7-d3c8-f2bf-dd8c-4704c663493d@microchip.com>
Date:   Fri, 5 Feb 2021 11:20:12 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Tudor Ambarus - M18064 <Tudor.Ambarus@...rochip.com>,
        "Claudiu Beznea - M18063" <Claudiu.Beznea@...rochip.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        Ludovic Desroches - M43218 <Ludovic.Desroches@...rochip.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: configs: at91: enable drivers for sam9x60

On 05/02/2021 at 11:12, Tudor Ambarus - M18064 wrote:
> On 2/5/21 11:54 AM, Claudiu Beznea wrote:
>> Enable drivers for sam9x60/sam9x60-ek:
>> - shutdown controller
>> - CAN
>> - AT24 EEPROM (present on SAM9X60-EK)
>> - MCP23S08 (present on SAM9X60-EK)
>> - AES, TDES, SHA
> 
> Crypto IPs are present only sam9x60. Should we have them as modules?

That's fine with me if we keep them as built-in.
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Regards,
   Nicolas

>> And use "make savedefconfig".
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> 
> With or without the Crypto IPs as modules:
> 
> Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
> 
>> ---
>>   arch/arm/configs/at91_dt_defconfig | 12 +++++++-----
>>   1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
>> index 5f3415c743ec..e274f8c492d2 100644
>> --- a/arch/arm/configs/at91_dt_defconfig
>> +++ b/arch/arm/configs/at91_dt_defconfig
>> @@ -17,8 +17,6 @@ CONFIG_SOC_SAM9X60=y
>>   # CONFIG_ATMEL_CLOCKSOURCE_PIT is not set
>>   CONFIG_AEABI=y
>>   CONFIG_UACCESS_WITH_MEMCPY=y
>> -CONFIG_ZBOOT_ROM_TEXT=0x0
>> -CONFIG_ZBOOT_ROM_BSS=0x0
>>   CONFIG_ARM_APPENDED_DTB=y
>>   CONFIG_ARM_ATAG_DTB_COMPAT=y
>>   CONFIG_CMDLINE="console=ttyS0,115200 initrd=0x21100000,25165824 root=/dev/ram0 rw"
>> @@ -38,6 +36,8 @@ CONFIG_IP_PNP_BOOTP=y
>>   CONFIG_IP_PNP_RARP=y
>>   # CONFIG_INET_DIAG is not set
>>   CONFIG_IPV6_SIT_6RD=y
>> +CONFIG_CAN=y
>> +CONFIG_CAN_AT91=y
>>   CONFIG_CFG80211=y
>>   CONFIG_MAC80211=y
>>   CONFIG_DEVTMPFS=y
>> @@ -58,6 +58,7 @@ CONFIG_BLK_DEV_RAM=y
>>   CONFIG_BLK_DEV_RAM_COUNT=4
>>   CONFIG_BLK_DEV_RAM_SIZE=8192
>>   CONFIG_ATMEL_SSC=y
>> +CONFIG_EEPROM_AT24=m
>>   CONFIG_SCSI=y
>>   CONFIG_BLK_DEV_SD=y
>>   # CONFIG_SCSI_LOWLEVEL is not set
>> @@ -91,7 +92,6 @@ CONFIG_RT2800USB_UNKNOWN=y
>>   CONFIG_RTL8187=m
>>   CONFIG_RTL8192CU=m
>>   # CONFIG_RTLWIFI_DEBUG is not set
>> -CONFIG_INPUT_POLLDEV=y
>>   CONFIG_INPUT_JOYDEV=y
>>   CONFIG_INPUT_EVDEV=y
>>   # CONFIG_KEYBOARD_ATKBD is not set
>> @@ -111,8 +111,8 @@ CONFIG_I2C_GPIO=y
>>   CONFIG_SPI=y
>>   CONFIG_SPI_ATMEL=y
>>   CONFIG_SPI_ATMEL_QUADSPI=y
>> +CONFIG_PINCTRL_MCP23S08=m
>>   CONFIG_POWER_RESET=y
>> -# CONFIG_POWER_RESET_AT91_SAMA5D2_SHDWC is not set
>>   CONFIG_POWER_SUPPLY=y
>>   # CONFIG_HWMON is not set
>>   CONFIG_WATCHDOG=y
>> @@ -208,7 +208,9 @@ CONFIG_NLS_UTF8=y
>>   CONFIG_CRYPTO_ECB=y
>>   CONFIG_CRYPTO_USER_API_HASH=m
>>   CONFIG_CRYPTO_USER_API_SKCIPHER=m
>> -# CONFIG_CRYPTO_HW is not set
>> +CONFIG_CRYPTO_DEV_ATMEL_AES=y
>> +CONFIG_CRYPTO_DEV_ATMEL_TDES=y
>> +CONFIG_CRYPTO_DEV_ATMEL_SHA=y
>>   CONFIG_CRC_CCITT=y
>>   CONFIG_FONTS=y
>>   CONFIG_FONT_8x8=y
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
> 

-- 
Nicolas Ferre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives