[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210205113805.GB18836@zhaomy-pc>
Date: Fri, 5 Feb 2021 19:38:06 +0800
From: Xin Ji <xji@...logixsemi.com>
To: Robert Foss <robert.foss@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>, David Airlie <airlied@...ux.ie>,
Nicolas Boichat <drinkcat@...gle.com>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Daniel Vetter <daniel@...ll.ch>,
Sam Ravnborg <sam@...nborg.org>,
Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
Maxime Ripard <mripard@...nel.org>,
Mark Brown <broonie@...nel.org>,
Ricardo CaƱuelo
<ricardo.canuelo@...labora.com>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, Bernie Liang <bliang@...logixsemi.com>,
Sheng Pan <span@...logixsemi.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings:drm/bridge:anx7625:add vendor define
flags
On Thu, Feb 04, 2021 at 01:38:36PM +0100, Robert Foss wrote:
> Hey Xin,
>
> On Thu, 28 Jan 2021 at 04:10, Xin Ji <xji@...logixsemi.com> wrote:
> >
> > Add 'bus-type' and 'data-lanes' define for port0, add HDCP support
> > flag and DP tx lane0 and lane1 swing register array define.
> >
> > Signed-off-by: Xin Ji <xji@...logixsemi.com>
> > ---
> > .../bindings/display/bridge/analogix,anx7625.yaml | 54 +++++++++++++++++++++-
> > 1 file changed, 53 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > index c789784..048deec 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> > @@ -34,6 +34,24 @@ properties:
> > description: used for reset chip control, RESET_N pin B7.
> > maxItems: 1
> >
> > + analogix,lane0-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + maxItems: 20
> > + description:
> > + an array of swing register setting for DP tx lane0 PHY, please don't
> > + add this property, or contact vendor.
> > +
> > + analogix,lane1-swing:
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + maxItems: 20
> > + description:
> > + an array of swing register setting for DP tx lane1 PHY, please don't
> > + add this property, or contact vendor.
> > +
> > + analogix,hdcp-support:
> > + type: boolean
> > + description: indicate the DP tx HDCP support or not.
> > +
> > ports:
> > $ref: /schemas/graph.yaml#/properties/ports
> >
> > @@ -41,13 +59,45 @@ properties:
> > port@0:
> > $ref: /schemas/graph.yaml#/properties/port
> > description:
> > - Video port for MIPI DSI input.
> > + Video port for MIPI input.
>
> Maybe MIPI DSI/DPI input is more correct, since there are a lot of
> other MIPI standards.
Hi Rob, OK, I'll change it in the next series.
Thanks,
Xin
>
> > +
> > + properties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + # Properties described in
> > + # Documentation/devicetree/bindings/media/video-interfaces.txt
> > + properties:
> > + remote-endpoint: true
> > + bus-type: true
> > + data-lanes: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > + required:
> > + - endpoint
> > +
> >
> > port@1:
> > $ref: /schemas/graph.yaml#/properties/port
> > description:
> > Video port for panel or connector.
> >
> > + properties:
> > + endpoint:
> > + type: object
> > + additionalProperties: false
> > +
> > + # Properties described in
> > + # Documentation/devicetree/bindings/media/video-interfaces.txt
> > + properties:
> > + remote-endpoint: true
> > +
> > + required:
> > + - remote-endpoint
> > +
> > required:
> > - port@0
> > - port@1
> > @@ -81,6 +131,8 @@ examples:
> > reg = <0>;
> > anx7625_in: endpoint {
> > remote-endpoint = <&mipi_dsi>;
> > + bus-type = <5>;
> > + data-lanes = <0 1 2 3>;
> > };
> > };
> >
> > --
> > 2.7.4
> >
Powered by blists - more mailing lists