linux-kernel - Re: [PATCH] RFC syscore: add suspend type to syscore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gvkF7y6a7ZeNippUAyWd7FfSKh4BmGS+ckT_HNkpQBTw@mail.gmail.com>
Date:   Fri, 5 Feb 2021 12:39:28 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ruifeng Zhang <ruifeng.zhang0110@...il.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        ruifeng.zhang1@...soc.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Chunyan Zhang <chunyan.zhang@...soc.com>, ke.wang@...soc.com,
        nianfu.bai@...soc.com, orson.zhai@...soc.com
Subject: Re: [PATCH] RFC syscore: add suspend type to syscore

On Fri, Feb 5, 2021 at 11:28 AM Ruifeng Zhang
<ruifeng.zhang0110@...il.com> wrote:
>
> Rafael J. Wysocki <rafael@...nel.org> 于2021年2月4日周四 下午9:38写道：
> >
> > On Thu, Feb 4, 2021 at 10:07 AM Ruifeng Zhang
> > <ruifeng.zhang0110@...il.com> wrote:
> > >
> > > Greg KH <gregkh@...uxfoundation.org> 于2021年1月29日周五 下午4:53写道：
> > > >
> > > > On Fri, Jan 29, 2021 at 04:27:26PM +0800, Ruifeng Zhang wrote:
> > > > > From: Ruifeng Zhang <ruifeng.zhang1@...soc.com>
> > > > >
> > > > > Suspend type contains s2ram and s2idle, but syscore is only
> > > > > available for S2RAM.
> > > >
> > > > Who else needs this?
> > > In the s2idle suspend and resume, some vendors want to do some
> > > things, for example the vendor implemented the watchdog driver.
> >
> > Do that in the platform operations then.
> >
> > Adding the syscore stuff to the suspend-to-idle flow is not an option, sorry.
> Excause me, I really still want to know the reason.

The conditions to run syscore operations are: with one CPU online and
with disabled interrupts on that CPU.  They are not satisfied in the
suspend-to-idle flow.  Moreover, none of the existing syscore
operations need to be executed for suspend-to-idle except for the
timekeeping suspend, but this is done for a special reason.

> My requirement is that the watchdog need disable when the system s2idle.
> If don't, the watchdog will bark when system resume.

So disabled it from s2idle_ops->prepare() or
suspend_ops->prepare_late() if device suspend is too early for you.