linux-kernel - [PATCH] coresight: etm4x: Fix merge resolution for amba rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210205130848.20009-1-uwe@kleine-koenig.org>
Date:   Fri,  5 Feb 2021 14:08:47 +0100
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        kvm@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Jaroslav Kysela <perex@...ex.cz>,
        Eric Anholt <eric@...olt.net>,
        Uwe Kleine-König 
        <u.kleine-koenig.org@...gutronix.de>, linux-i2c@...r.kernel.org,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-stm32@...md-mailman.stormreply.com,
        linux-watchdog@...r.kernel.org, linux-rtc@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Takashi Iwai <tiwai@...e.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-serial@...r.kernel.org, linux-input@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Mike Leach <mike.leach@...aro.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        alsa-devel@...a-project.org,
        Suzuki K Poulose <suzuki.poulose@....com>,
        coresight@...ts.linaro.org, Vladimir Zapolskiy <vz@...ia.com>,
        Eric Auger <eric.auger@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        Matt Mackall <mpm@...enic.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Cornelia Huck <cohuck@...hat.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        Vinod Koul <vkoul@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        linux-crypto@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>,
        Leo Yan <leo.yan@...aro.org>, dmaengine@...r.kernel.org
Subject: [PATCH] coresight: etm4x: Fix merge resolution for amba rework

This was non-trivial to get right because commits
c23bc382ef0e ("coresight: etm4x: Refactor probing routine") and
5214b563588e ("coresight: etm4x: Add support for sysreg only devices")
changed the code flow considerably. With this change the driver can be
built again.

Fixes: 0573d3fa4864 ("Merge branch 'devel-stable' of git://git.armlinux.org.uk/~rmk/linux-arm into char-misc-next")
Signed-off-by: Uwe Kleine-König <uwe@...ine-koenig.org>
---
On Fri, Feb 05, 2021 at 12:07:09PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Feb 05, 2021 at 11:56:15AM +0100, Uwe Kleine-König wrote:
> > I didn't compile test, but I'm willing to bet your resolution is wrong.
> > You have no return statement in etm4_remove_dev() but its return type is
> > int and etm4_remove_amba() still returns int but should return void.
> 
> Can you send a patch to fix this up?

Sure, here it comes. As I'm unsure if you want to squash it into the
merge or want to keep it separate I crafted a commit message. If you
prefer squashing feel free to do so.

This change corresponds to the merge resolution I suggested before.

Best regards
Uwe

 drivers/hwtracing/coresight/coresight-etm4x-core.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
index bc55b261af23..c8ecd91e289e 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
@@ -1906,15 +1906,16 @@ static int __exit etm4_remove_dev(struct etmv4_drvdata *drvdata)
 	cpus_read_unlock();
 
 	coresight_unregister(drvdata->csdev);
+
+	return 0;
 }
 
-static int __exit etm4_remove_amba(struct amba_device *adev)
+static void __exit etm4_remove_amba(struct amba_device *adev)
 {
 	struct etmv4_drvdata *drvdata = dev_get_drvdata(&adev->dev);
 
 	if (drvdata)
-		return etm4_remove_dev(drvdata);
-	return 0;
+		etm4_remove_dev(drvdata);
 }
 
 static int __exit etm4_remove_platform_dev(struct platform_device *pdev)
-- 
2.29.2