linux-kernel - Re: [PATCH] alarmtimer: Do not mess with an enqueued hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o8gy8mug.fsf@nanos.tec.linutronix.de>
Date:   Fri, 05 Feb 2021 18:07:35 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Li RongQing <lirongqing@...du.com>, linux-kernel@...r.kernel.org,
        john.stultz@...aro.org
Subject: Re: [PATCH] alarmtimer: Do not mess with an enqueued hrtimer

On Thu, Jan 07 2021 at 13:33, Li RongQing wrote:
> when an hrtimer is enqueued already, its expires should be not
> changed, otherwise, this will corrupts the ordering of the
> timerqueue RB tree, if other hrtimer is enqueued before this
> hrtimer is restarted, whole RB tree is completely hosed
>
> Fixes: 6cffe00f7d4e ("alarmtimer: Add functions for timerfd support")

I can't see what this fixes. alarm_restart() is only invoked when the
alarm has expired which means that the timer _cannot_ be queued.

Thanks,

        tglx