linux-kernel - Re: [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for BCM2711's ARSAN ASB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21b99f074d6e4ce469cb37d3b73c2cce5c728200.camel@suse.de>
Date:   Fri, 05 Feb 2021 19:30:46 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     phil@...pberrypi.com, Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>
Cc:     wahrenst@....net, linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 05/11] soc: bcm: bcm2835-power: Add support for
 BCM2711's ARSAN ASB

Hi Florian, Phil,

On Fri, 2021-02-05 at 08:56 -0800, Florian Fainelli wrote:
> On 2/5/21 5:52 AM, Nicolas Saenz Julienne wrote:
> > In BCM2711 the new ARGON ASB took over V3D. The old ASB is still present
> > with the ISP and H264 bits, and V3D is in the same place in the new ASB
> > as the old one.
> > 
> > Use the fact that 'pm->arsan_asb' is populated as a hint that we're on
> > BCM2711. On top of that introduce the macro ASB_BASE() which will select
> > the correct ASB register base, based on whether we're trying to access
> > V3D and which platform we're on.
> 
> Your subject has a typo, you most likely intended to write "Argon ASB",
> right?

Yes, sorry for that, the typo is also present in code. I mindlessly decided
both words meant the same and went with it...

So, for the record, s/arsan/argon/ should be applied on all patches, binding is
fine in that regards. On the other hand, the old arsan/rpivid ASB is referenced
as 'asb' in code, and as 'arsan' in the bindings, I'll rename both to 'rpivid'
in v2.

Actually, if all this is too confusing, let me know and I'll send a v2 right
away.

> I will review the series a little later today.

Thanks!
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)