linux-kernel - Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 5 Feb 2021 19:37:28 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>,
        Sven Schuchmann <schuchmann@...leissheimer.de>
Cc:     Dan Murphy <dmurphy@...com>, Rob Herring <robh+dt@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity
 from DT

Hi Pavel,

On 2/5/21 11:23 AM, Pavel Machek wrote:
> Hi!
> 
>>>>       patternProperties:
>>>>         "(^led-[0-9a-f]$|led)":
>>>> @@ -99,6 +104,7 @@ examples:
>>>>                  reg = <0x1>;
>>>>                  color = <LED_COLOR_ID_RGB>;
>>>>                  function = LED_FUNCTION_CHARGING;
>>>> +               default-intensity = <100 0 0>;

How will you know which array position is for which child LED?
I presume DT child nodes are not guaranteed to be parsed in the order
of declaration?

>>>>
>>>>                  led-0 {
>>>>                      color = <LED_COLOR_ID_RED>;
>>>
>>> Should this go to leds-class-multicolor.yaml ?
>>
>> I think then all drivers should support it,  but I cannot change all drivers.
>> So I would only leave it in there.
> 
> It really should be in common binding, and no, that does not mean you
> need to change all the drivers.
> 
> Plus there's at most two of them at the moment.
> 
> Best regards,
> 							Pavel
> 

-- 
Best regards,
Jacek Anaszewski