linux-kernel - Re: [PATCH 1/8] spi: stm32: properly handle 0 byte transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210205132942.GA4720@sirena.org.uk>
Date:   Fri, 5 Feb 2021 13:29:42 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Alain Volmat <alain.volmat@...s.st.com>
Cc:     amelie.delaunay@...s.st.com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...s.st.com, linux-spi@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fabrice.gasnier@...s.st.com
Subject: Re: [PATCH 1/8] spi: stm32: properly handle 0 byte transfer

On Fri, Feb 05, 2021 at 12:08:55PM +0100, Alain Volmat wrote:
> On 0 byte transfer request, return straight from the
> xfer function after finalizing the transfer.

> +	if (transfer->len == 0) {
> +		spi_finalize_current_transfer(master);
> +		return 0;

The driver only needs to finalize the transfer if it returned a value
greater than 0, returning 0 indicates that the transfer is already done.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)