linux-kernel - Re: [PATCH v5 3/7] dt-bindings: arm: cpus: Document 'qcom,freq-domain' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65135511-1360-c094-9eaf-fec75f9ab53a@somainline.org>
Date:   Fri, 5 Feb 2021 23:22:56 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Rob Herring <robh@...nel.org>
Cc:     viresh.kumar@...aro.org, bjorn.andersson@...aro.org,
        agross@...nel.org, rjw@...ysocki.net, devicetree@...r.kernel.org,
        amit.kucheria@...aro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        konrad.dybcio@...ainline.org, marijn.suijten@...ainline.org,
        martin.botka@...ainline.org, jeffrey.l.hugo@...il.com,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH v5 3/7] dt-bindings: arm: cpus: Document
 'qcom,freq-domain' property

Il 05/02/21 22:46, Rob Herring ha scritto:
> On Thu, Jan 21, 2021 at 08:52:46PM +0100, AngeloGioacchino Del Regno wrote:
>> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>>
>> Add devicetree documentation for 'qcom,freq-domain' property specific
>> to Qualcomm CPUs. This property is used to reference the CPUFREQ node
>> along with Domain ID (0/1).
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
>> ---
>>   Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>> index 14cd727d3c4b..1d60975df23a 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>> @@ -290,6 +290,12 @@ properties:
>>   
>>         * arm/msm/qcom,kpss-acc.txt
>>   
>> +  qcom,freq-domain:
> 
> What happened to having a standard property here? There were 1 or 2
> other cases of doing the same thing.
> 

The original discussion didn't have any more replies, so I thought to
bring it back on the table.
I have no idea about what are the other cases, but if you can suggest
a different property name (just "frequency-domain"?) I can send a new
one with the suggested one!

Though, since I don't know about other cases, how would this get
described?

frequency-domain:
"CPUs supporting frequency-domain must set this property with phandle
  to the appropriate [domain node or cpufreq node?] followed by the
  Domain ID"

Would this be fine?

Thanks,
- Angelo

>> +    $ref: '/schemas/types.yaml#/definitions/phandle-array'
>> +    description: |
>> +      CPUs supporting freq-domain must set their "qcom,freq-domain" property
>> +      with phandle to a cpufreq_hw node followed by the Domain ID(0/1).
>> +
>>     rockchip,pmu:
>>       $ref: '/schemas/types.yaml#/definitions/phandle'
>>       description: |
>> -- 
>> 2.30.0
>>