linux-kernel - RE: [PATCH 1/2] platform/chrome: cros_ec_typec: Skip port partner check in configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3963CE613ED4F666EBDA27E6F6B29@DM6PR11MB3963.namprd11.prod.outlook.com>
Date:   Fri, 5 Feb 2021 22:56:20 +0000
From:   "Mani, Rajmohan" <rajmohan.mani@...el.com>
To:     Prashant Malani <pmalani@...omium.org>
CC:     Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: RE: [PATCH 1/2] platform/chrome: cros_ec_typec: Skip port partner
 check in configure_mux()

Hi Prashant,

> -----Original Message-----
> From: Prashant Malani <pmalani@...omium.org>
> Sent: Friday, February 05, 2021 12:07 PM
> To: Mani, Rajmohan <rajmohan.mani@...el.com>
> Cc: Benson Leung <bleung@...omium.org>; Enric Balletbo i Serra
> <enric.balletbo@...labora.com>; Guenter Roeck <groeck@...omium.org>;
> Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; Heikki Krogerus
> <heikki.krogerus@...ux.intel.com>
> Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_typec: Skip port partner
> check in configure_mux()
> 
> Hi Raj,
> 
> On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani
> <rajmohan.mani@...el.com> wrote:
> >
> > For certain needs like updating the USB4 retimer firmware when no
> > device are connected, the Type-C ports require mux configuration, to
> > be able to communicate with the retimer. So removed the above check to
> > allow for mux configuration of Type-C ports, to enable retimer
> > communication.
> >
> > Signed-off-by: Rajmohan Mani <rajmohan.mani@...el.com>
> Reviewed-by: Prashant Malani <pmalani@...omium.org>
> 

Thanks for the review of the patch series.

> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c
> > b/drivers/platform/chrome/cros_ec_typec.c
> > index e724a5eaef1c..3d8ff3f8a514 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -536,9 +536,6 @@ static int cros_typec_configure_mux(struct
> cros_typec_data *typec, int port_num,
> >         enum typec_orientation orientation;
> >         int ret;
> >
> > -       if (!port->partner)
> > -               return 0;
> > -
> >         if (mux_flags & USB_PD_MUX_POLARITY_INVERTED)
> >                 orientation = TYPEC_ORIENTATION_REVERSE;
> >         else
> > --
> > 2.30.0
> >