linux-kernel - Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE1WUT5XKgi10sMaCUFqENUffgUzCF-jrAJE9z=wKkW=yP_9mw@mail.gmail.com>
Date:   Fri, 5 Feb 2021 20:28:30 -0800
From:   Amy Parker <enbyamy@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     davem@...emloft.net, kuba@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>, rppt@...nel.org,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

On Fri, Feb 5, 2021 at 7:16 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 2/5/21 4:01 PM, Amy Parker wrote:
> > This patchset updates atarilance.c and sun3lance.c to follow the kernel
> > style guide. Each patch tackles a different issue in the style guide.
> >
> >    -Amy IP
> >
> > Amy Parker (3):
> >   drivers/net/ethernet/amd: Correct spacing around C keywords
> >   drivers/net/ethernet/amd: Fix bracket matching and line levels
> >   drivers/net/ethernet/amd: Break apart one-lined expressions
> >
> >  drivers/net/ethernet/amd/atarilance.c | 64 ++++++++++++++-------------
> >  drivers/net/ethernet/amd/sun3lance.c  | 64 +++++++++++++++------------
> >  2 files changed, 69 insertions(+), 59 deletions(-)
> >
>
> Hi Amy,
>
> For each patch, can you confirm that the before & after binary files
> are the same?  or if they are not the same, explain why not?
>
> Just something that I have done in the past...
>
> thanks.

At least when I tried - yes. These are just stylistic changes.
Currently using gcc version 10.2.1.

   -Amy IP