linux-kernel - Re: [PATCH net-next] net: Return the correct errno code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210206111812.284f2bc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 6 Feb 2021 11:18:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     Zheng Yongjun <zhengyongjun3@...wei.com>, <davem@...emloft.net>,
        <linux-decnet-user@...ts.sourceforge.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: Return the correct errno code

On Thu, 4 Feb 2021 11:14:26 -0800 Jesse Brandeburg wrote:
> Zheng Yongjun wrote:
> 
> > When kzalloc failed, should return ENOMEM rather than ENOBUFS.  
> 
> All these patches have the same subject and description, couldn't they
> just be part of a single series with a good cover letter?

Agreed. The patches seem to be lacking clear justification.
Cover letter would be good.

> I'm not saying make them a single patch, because that is bad for
> bisection, but having them as a single series means we review related
> changes at one time, and can comment on them as a group.