linux-kernel - fs/cifs/inode.c:2882:1: warning: stack frame size of 2096 bytes in function 'cifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202102070639.0S6zVq4k-lkp@intel.com>
Date:   Sun, 7 Feb 2021 06:08:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ronnie Sahlberg <lsahlber@...hat.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org, Steve French <stfrench@...rosoft.com>
Subject: fs/cifs/inode.c:2882:1: warning: stack frame size of 2096 bytes in
 function 'cifs_setattr'

Hi Ronnie,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   61556703b610a104de324e4f061dc6cf7b218b46
commit: c6cc4c5a72505a0ecefc9b413f16bec512f38078 cifs: handle -EINTR in cifs_setattr
date:   4 months ago
config: powerpc64-randconfig-r025-20210205 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6cc4c5a72505a0ecefc9b413f16bec512f38078
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout c6cc4c5a72505a0ecefc9b413f16bec512f38078
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/cifs/inode.c:2882:1: warning: stack frame size of 2096 bytes in function 'cifs_setattr' [-Wframe-larger-than=]
   cifs_setattr(struct dentry *direntry, struct iattr *attrs)
   ^
   1 warning generated.


vim +/cifs_setattr +2882 fs/cifs/inode.c

^1da177e4c3f41 Linus Torvalds  2005-04-16  2880  
0510eeb7367aca Jeff Layton     2008-08-02  2881  int
0510eeb7367aca Jeff Layton     2008-08-02 @2882  cifs_setattr(struct dentry *direntry, struct iattr *attrs)
0510eeb7367aca Jeff Layton     2008-08-02  2883  {
fc64005c93090c Al Viro         2016-04-10  2884  	struct cifs_sb_info *cifs_sb = CIFS_SB(direntry->d_sb);
96daf2b09178d8 Steve French    2011-05-27  2885  	struct cifs_tcon *pTcon = cifs_sb_master_tcon(cifs_sb);
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2886  	int rc, retries = 0;
0510eeb7367aca Jeff Layton     2008-08-02  2887  
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2888  	do {
0510eeb7367aca Jeff Layton     2008-08-02  2889  		if (pTcon->unix_ext)
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2890  			rc = cifs_setattr_unix(direntry, attrs);
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2891  		else
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2892  			rc = cifs_setattr_nounix(direntry, attrs);
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2893  		retries++;
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2894  	} while (is_retryable_error(rc) && retries < 2);
0510eeb7367aca Jeff Layton     2008-08-02  2895  
0510eeb7367aca Jeff Layton     2008-08-02  2896  	/* BB: add cifs_setattr_legacy for really old servers */
c6cc4c5a72505a Ronnie Sahlberg 2020-10-09  2897  	return rc;
0510eeb7367aca Jeff Layton     2008-08-02  2898  }
0510eeb7367aca Jeff Layton     2008-08-02  2899  

:::::: The code at line 2882 was first introduced by commit
:::::: 0510eeb7367aca017c6320d04cfd9cbc3b5dd992 turn cifs_setattr into a multiplexor that calls the correct function

:::::: TO: Jeff Layton <jlayton@...hat.com>
:::::: CC: Steve French <sfrench@...ibm.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36809 bytes)