lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 7 Feb 2021 15:44:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, shaggy@...nel.org
Cc:     kbuild-all@...ts.01.org, jfs-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Yang Li <yang.lee@...ux.alibaba.com>
Subject: Re: [PATCH] jfs: turn diLog(), dataLog() and txLog() into void
 functions

Hi Yang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shaggy/jfs-next]
[also build test WARNING on v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
base:   https://github.com/kleikamp/linux-shaggy jfs-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8b7ab4ba41269109e7cb95106023e96d640842e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
        git checkout 8b7ab4ba41269109e7cb95106023e96d640842e9
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/jfs/jfs_txnmgr.c:1368:13: error: conflicting types for 'txLog'
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:162:12: note: previous declaration of 'txLog' was here
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: error: conflicting types for 'diLog'
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:151:12: note: previous declaration of 'diLog' was here
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: error: conflicting types for 'dataLog'
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:153:12: note: previous declaration of 'dataLog' was here
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:151:12: warning: 'diLog' used but never defined
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
>> fs/jfs/jfs_txnmgr.c:153:12: warning: 'dataLog' used but never defined
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:162:12: warning: 'txLog' used but never defined
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: warning: 'dataLog' defined but not used [-Wunused-function]
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: warning: 'diLog' defined but not used [-Wunused-function]
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:1368:13: warning: 'txLog' defined but not used [-Wunused-function]
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~


vim +/diLog +151 fs/jfs/jfs_txnmgr.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  147  
^1da177e4c3f41 Linus Torvalds 2005-04-16  148  /*
^1da177e4c3f41 Linus Torvalds 2005-04-16  149   * forward references
^1da177e4c3f41 Linus Torvalds 2005-04-16  150   */
^1da177e4c3f41 Linus Torvalds 2005-04-16 @151  static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  152  		struct tlock * tlck, struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @153  static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  154  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  155  static void dtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  156  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  157  static void mapLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  158  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  159  static void txAllocPMap(struct inode *ip, struct maplock * maplock,
^1da177e4c3f41 Linus Torvalds 2005-04-16  160  		struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  161  static void txForce(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @162  static int txLog(struct jfs_log * log, struct tblock * tblk,
^1da177e4c3f41 Linus Torvalds 2005-04-16  163  		struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16  164  static void txUpdateMap(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  165  static void txRelease(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  166  static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  167  	   struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  168  static void LogSyncRelease(struct metapage * mp);
^1da177e4c3f41 Linus Torvalds 2005-04-16  169  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (38339 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ