linux-kernel - Re: [PATCH] iommu/mediatek: Fix error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Feb 2021 09:45:19 +0800
From:   Yong Wu <yong.wu@...iatek.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Joerg Roedel <joro@...tes.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Tomasz Figa <tfiga@...omium.org>,
        <iommu@...ts.linux-foundation.org>,
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Will Deacon <will@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] iommu/mediatek: Fix error code in probe()

On Fri, 2021-02-05 at 15:46 +0300, Dan Carpenter wrote:
> This error path is supposed to return -EINVAL.  It used to return
> directly but we added some clean up and accidentally removed the
> error code.  Also I fixed a typo in the error message.
> 
> Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Yong Wu <yong.wu@...iatek.com>

> ---
>  drivers/iommu/mtk_iommu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 0ad14a7604b1..5f78ac0dc30e 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -886,7 +886,8 @@ static int mtk_iommu_probe(struct platform_device *pdev)
>  	link = device_link_add(data->smicomm_dev, dev,
>  			DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
>  	if (!link) {
> -		dev_err(dev, "Unable link %s.\n", dev_name(data->smicomm_dev));
> +		dev_err(dev, "Unable to link %s.\n", dev_name(data->smicomm_dev));
> +		ret = -EINVAL;
>  		goto out_runtime_disable;
>  	}
>