linux-kernel - Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 7 Feb 2021 11:32:14 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Colton Booth <colton@...thsoftware.ca>, dmitry.torokhov@...il.com
Cc:     colton@...thlinux.ca, Lyude Paul <lyude@...hat.com>,
        Lee Jones <lee.jones@...aro.org>,
        Vincent Huang <vincent.huang@...synaptics.com>,
        Dennis Kadioglu <denk@...ipso.email>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Yussuf Khalil <dev@...345.net>, Ilya Katsnelson <me@...ti.me>,
        Gaurav Agrawal <agrawalgaurav@...me.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: synaptic - reverting
 dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for
 one guy on Reddit.

Hi,

On 2/7/21 11:18 AM, Hans de Goede wrote:
> Hi,
> 
> On 2/7/21 4:50 AM, Colton Booth wrote:
>> I can't test myself since I don't have the correct hardware, BUT this change seems to work for him. I'm thinking he has an early version of the X1E which may use slightly different trackpad revision.
> 
> Who is "him"? Do you have a bug-report link or some such ?
> 
> With which kernel version is this ?  Could it be that the commit you are reverting was
> backported to a stable-series release while that stable series is missing the rmi4
> updates necessary to make things work on newer models ?
> 
> What are the symptoms / problems "him" is seeing when not reverting this?
> 
> On case it is not clear: NACK due to insufficient information why this is
> necessary / missing description and root cause analysis of the actual problem.

p.s.

My apologies if this sounds a bit grumpy, I got out of bed on the wrong side this morning.

Regards,

Hans





> 
> Regards,
> 
> Hans
> 
> 
>>
>> Signed-off-by: Colton Booth <colton@...thsoftware.ca>
>> ---
>>  drivers/input/mouse/synaptics.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> index ffad142801b3..2d3f03921dbc 100644
>> --- a/drivers/input/mouse/synaptics.c
>> +++ b/drivers/input/mouse/synaptics.c
>> @@ -179,9 +179,7 @@ static const char * const smbus_pnp_ids[] = {
>>  	"LEN0093", /* T480 */
>>  	"LEN0096", /* X280 */
>>  	"LEN0097", /* X280 -> ALPS trackpoint */
>> -	"LEN0099", /* X1 Extreme Gen 1 / P1 Gen 1 */
>>  	"LEN009b", /* T580 */
>> -	"LEN0402", /* X1 Extreme Gen 2 / P1 Gen 2 */
>>  	"LEN200f", /* T450s */
>>  	"LEN2044", /* L470  */
>>  	"LEN2054", /* E480 */
>>