| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 8 Feb 2021 02:51:24 +0800
From: kernel test robot <lkp@...el.com>
To: "Daniel W. S. Almeida" <dwlsalmeida@...il.com>
Cc: kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
linux-kernel@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org
Subject: drivers/media/test-drivers/vidtv/vidtv_psi.c:1457:31: warning:
taking address of packed member 'bitfield' of class or structure
'vidtv_psi_table_nit' may result in an unaligned pointer value
Hi Daniel,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 61556703b610a104de324e4f061dc6cf7b218b46
commit: c2f78f0cb294aa6f009d3a170f4ee8ad199ba5da media: vidtv: psi: add a Network Information Table (NIT)
date: 2 months ago
config: mips-randconfig-r032-20210207 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c2f78f0cb294aa6f009d3a170f4ee8ad199ba5da
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout c2f78f0cb294aa6f009d3a170f4ee8ad199ba5da
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/media/test-drivers/vidtv/vidtv_psi.c:753:31: warning: taking address of packed member 'bitfield2' of class or structure 'vidtv_psi_table_pmt' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&pmt->bitfield2, desc_loop_len, 10);
^~~~~~~~~~~~~~
drivers/media/test-drivers/vidtv/vidtv_psi.c:764:32: warning: taking address of packed member 'bitfield2' of class or structure 'vidtv_psi_table_pmt_stream' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&s->bitfield2, desc_loop_len, 10);
^~~~~~~~~~~~
drivers/media/test-drivers/vidtv/vidtv_psi.c:796:32: warning: taking address of packed member 'bitfield' of class or structure 'vidtv_psi_table_sdt_service' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&s->bitfield, desc_loop_len, 12);
^~~~~~~~~~~
>> drivers/media/test-drivers/vidtv/vidtv_psi.c:1457:31: warning: taking address of packed member 'bitfield' of class or structure 'vidtv_psi_table_nit' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&nit->bitfield, desc_loop_len, 12);
^~~~~~~~~~~~~
>> drivers/media/test-drivers/vidtv/vidtv_psi.c:1472:32: warning: taking address of packed member 'bitfield' of class or structure 'vidtv_psi_table_transport' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&t->bitfield, desc_loop_len, 12);
^~~~~~~~~~~
>> drivers/media/test-drivers/vidtv/vidtv_psi.c:1480:31: warning: taking address of packed member 'bitfield2' of class or structure 'vidtv_psi_table_nit' may result in an unaligned pointer value [-Waddress-of-packed-member]
vidtv_psi_set_desc_loop_len(&nit->bitfield2, transport_loop_len, 12);
^~~~~~~~~~~~~~
drivers/media/test-drivers/vidtv/vidtv_psi.c:92:19: warning: unused function 'vidtv_psi_sdt_serv_get_desc_loop_len' [-Wunused-function]
static inline u16 vidtv_psi_sdt_serv_get_desc_loop_len(struct vidtv_psi_table_sdt_service *s)
^
drivers/media/test-drivers/vidtv/vidtv_psi.c:103:19: warning: unused function 'vidtv_psi_pmt_stream_get_desc_loop_len' [-Wunused-function]
static inline u16 vidtv_psi_pmt_stream_get_desc_loop_len(struct vidtv_psi_table_pmt_stream *s)
^
drivers/media/test-drivers/vidtv/vidtv_psi.c:114:19: warning: unused function 'vidtv_psi_pmt_get_desc_loop_len' [-Wunused-function]
static inline u16 vidtv_psi_pmt_get_desc_loop_len(struct vidtv_psi_table_pmt *p)
^
9 warnings generated.
vim +1457 drivers/media/test-drivers/vidtv/vidtv_psi.c
1442
1443 static void vidtv_psi_nit_table_update_sec_len(struct vidtv_psi_table_nit *nit)
1444 {
1445 u16 length = 0;
1446 struct vidtv_psi_table_transport *t = nit->transport;
1447 u16 desc_loop_len;
1448 u16 transport_loop_len = 0;
1449
1450 /*
1451 * from immediately after 'section_length' until
1452 * 'network_descriptor_length'
1453 */
1454 length += NIT_LEN_UNTIL_NETWORK_DESCRIPTOR_LEN;
1455
1456 desc_loop_len = vidtv_psi_desc_comp_loop_len(nit->descriptor);
> 1457 vidtv_psi_set_desc_loop_len(&nit->bitfield, desc_loop_len, 12);
1458
1459 length += desc_loop_len;
1460
1461 length += sizeof_field(struct vidtv_psi_table_nit, bitfield2);
1462
1463 while (t) {
1464 /* skip both pointers at the end */
1465 transport_loop_len += sizeof(struct vidtv_psi_table_transport) -
1466 sizeof(struct vidtv_psi_desc *) -
1467 sizeof(struct vidtv_psi_table_transport *);
1468
1469 length += transport_loop_len;
1470
1471 desc_loop_len = vidtv_psi_desc_comp_loop_len(t->descriptor);
> 1472 vidtv_psi_set_desc_loop_len(&t->bitfield, desc_loop_len, 12);
1473
1474 length += desc_loop_len;
1475
1476 t = t->next;
1477 }
1478
1479 // Actually sets the transport stream loop len, maybe rename this function later
> 1480 vidtv_psi_set_desc_loop_len(&nit->bitfield2, transport_loop_len, 12);
1481 length += CRC_SIZE_IN_BYTES;
1482
1483 vidtv_psi_set_sec_len(&nit->header, length);
1484 }
1485
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (28459 bytes)
Powered by blists - more mailing lists