linux-kernel - Re: [PATCH] USB: serial: drop bogus to_usb_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCFqFdqE64/UaX6o@kroah.com>
Date:   Mon, 8 Feb 2021 17:43:01 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: drop bogus to_usb_serial_port() checks

On Mon, Feb 08, 2021 at 04:48:06PM +0100, Johan Hovold wrote:
> The to_usb_serial_port() macro is implemented using container_of() so
> there's no need to check for NULL.
> 
> Note that neither bus match() or probe() is ever called with a NULL
> struct device pointer so the checks weren't just misplaced.
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>