linux-kernel - Re: [PATCH 1/5] sched: make struct task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210208164503.GA32698@localhost.localdomain>
Date:   Mon, 8 Feb 2021 19:45:03 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

On Mon, Feb 08, 2021 at 04:25:35PM +0100, Peter Zijlstra wrote:
> On Mon, Feb 08, 2021 at 05:52:45PM +0300, Alexey Dobriyan wrote:
> > On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote:
> > > On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote:
> > > > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote:
> > > > 
> > > > > Silently delete "extern" from prototypes.
> > > > 
> > > > NAK, extern is right.
> > > 
> > > Extern is only necessary for variables.
> > 
> > Specifically C17, 6.2.2 p5 (linkage of identifiers):
> > 
> > 	if the declaration of an identifier for a function has no
> > 	storage-class specifier, its linkage is determined exactly as if
> > 	it were declared with the storage-class specifier "extern".
> > 
> > This is why nothing happens if "extern" is deleted.
> 
> I know, but I still very much like extern on the function declarations
> too. It tells me the definition isn't to be found in this TU.

What can I say. The absense of function body should tell that.