linux-kernel - Re: [PATCH v10 7/7] at24: Support probing while off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jUqtYDpBn-ezsftCrY=9iD3sAKhyyFf_+CMkthLnsZow@mail.gmail.com>
Date:   Mon, 8 Feb 2021 17:54:33 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rajmohan Mani <rajmohan.mani@...el.com>,
        Tomasz Figa <tfiga@...omium.org>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@...el.com>,
        Hyungwoo Yang <hyungwoo.yang@...el.com>,
        linux-media <linux-media@...r.kernel.org>
Subject: Re: [PATCH v10 7/7] at24: Support probing while off

On Mon, Feb 8, 2021 at 5:44 PM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> On Fri, Feb 5, 2021 at 2:25 PM Sakari Ailus
> <sakari.ailus@...ux.intel.com> wrote:
> >
> > In certain use cases (where the chip is part of a camera module, and the
> > camera module is wired together with a camera privacy LED), powering on
> > the device during probe is undesirable. Add support for the at24 to
> > execute probe while being powered off. For this to happen, a hint in form
> > of a device property is required from the firmware.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Reviewed-by: Tomasz Figa <tfiga@...omium.org>
> > ---
>
> I'll ack this but I still claim that the name
> acpi_dev_state_low_power() is super misleading for this use-case and
> I've been saying that for 10 versions now with everyone just ignoring
> my remarks. :/

Well, the function in question simply checks if the current ACPI power
state of the device is different from "full power", so its name
appears to be quite adequate to me.

If the way in which it is used is confusing, though, I guess
explaining what's going on would be welcome.

> Acked-by: Bartosz Golaszewski <bgolaszewski@...libre.com>