linux-kernel - Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+BsgvZMi9PaEgAG-Q=1p1TRHsOJxrSJxiHxMSQO08r1w@mail.gmail.com>
Date:   Mon, 8 Feb 2021 11:00:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Steen Hegelund <steen.hegelund@...rochip.com>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Andrew Lunn <andrew@...n.ch>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch
 reset driver

On Mon, Feb 8, 2021 at 7:20 AM Steen Hegelund
<steen.hegelund@...rochip.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote:
> > > This provides reset driver support for the Microchip Sparx5 PCB134
> > > and
> > > PCB135 reference boards.
> >
> > This isn't a compatible change. You need an explanation why that's
> > okay
> > if that's intended.
>
> I am not entirely sure that I get your point.
>
> The change (adding the reset driver) is new, and it is optional (but
> strongly recommended) for the  clients to use it, so will this be a
> incompatible change?

I'm assuming something used "microchip,sparx5-chip-reset"?

> I can certainly add a an explanation.  Would that be needed here in the
> bindings, or where do you suggest?

Just need to spell out why dropping that is okay in the commit msg.
But I guess what this looks like will change anyways.

Rob