linux-kernel - RE: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to yaml schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6687E8BF45496B8505A6EC118F8F9@VE1PR04MB6687.eurprd04.prod.outlook.com>
Date:   Mon, 8 Feb 2021 17:07:14 +0000
From:   Leo Li <leoyang.li@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>
Subject: RE: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to
 yaml schema



> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Monday, February 8, 2021 10:55 AM
> To: Leo Li <leoyang.li@....com>
> Cc: linux-arm-kernel@...ts.infradead.org; Oleksij Rempel <linux@...pel-
> privat.de>; Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzk@...nel.org>; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; Shawn Guo <shawnguo@...nel.org>
> Subject: Re: [PATCH 03/15] dt-bindings: memory: fsl: convert ifc binding to
> yaml schema
> 
> On Fri, 05 Feb 2021 17:47:22 -0600, Li Yang wrote:
> > Convert the txt binding to yaml format and add description.  Also
> > updated the recommended node name to ifc-bus to align with the
> > simple-bus node name requirements.
> >
> > Signed-off-by: Li Yang <leoyang.li@....com>
> > ---
> >  .../bindings/memory-controllers/fsl/ifc.txt   |  82 ----------
> >  .../bindings/memory-controllers/fsl/ifc.yaml  | 140
> > ++++++++++++++++++
> >  2 files changed, 140 insertions(+), 82 deletions(-)  delete mode
> > 100644
> > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/memory-controllers/fsl/ifc.yaml
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/memory-
> controllers/fsl/ifc.example.dts:36.27-49.19: Warning (simple_bus_reg):
> /example-0/soc/ifc-bus@...1e000/flash@0,0: simple-bus unit address
> format error, expected "0"
> Documentation/devicetree/bindings/memory-
> controllers/fsl/ifc.example.dts:51.27-64.19: Warning (simple_bus_reg):
> /example-0/soc/ifc-bus@...1e000/flash@1,0: simple-bus unit address
> format error, expected "100000000"
> Documentation/devicetree/bindings/memory-
> controllers/fsl/ifc.example.dts:66.26-71.19: Warning (simple_bus_reg):
> /example-0/soc/ifc-bus@...1e000/cpld@3,0: simple-bus unit address format
> error, expected "300000000"

Hi Rob,

I saw these warnings, but cannot find a good solution to it.  The first cell in the address is the Chip select, while the second cell in the address is the address offset within the chip select.  It would confusing to combine the two cells of different purposes into a single address as suggested by the warning.  Can we allow the multi-cell address in the node name?

Regards,
Leo