linux-kernel - Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210208172403.GT308988@casper.infradead.org>
Date:   Mon, 8 Feb 2021 17:24:03 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Kalesh Singh <kaleshsingh@...gle.com>, jannh@...gle.com,
        jeffv@...gle.com, keescook@...omium.org, surenb@...gle.com,
        minchan@...nel.org, hridya@...gle.com, rdunlap@...radead.org,
        christian.koenig@....com, kernel-team@...roid.com,
        Jonathan Corbet <corbet@....net>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Alexey Gladkov <gladkov.alexey@...il.com>,
        NeilBrown <neilb@...e.de>, Anand K Mistry <amistry@...gle.com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Michel Lespinasse <walken@...gle.com>,
        Bernd Edlinger <bernd.edlinger@...mail.de>,
        Andrei Vagin <avagin@...il.com>,
        Yafang Shao <laoar.shao@...il.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo

On Mon, Feb 08, 2021 at 08:17:34PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 08, 2021 at 03:22:44PM +0000, Matthew Wilcox wrote:
> > On Mon, Feb 08, 2021 at 03:14:28PM +0000, Kalesh Singh wrote:
> > > -	seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n",
> > > +	seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\ninode_no:\t%lu\n",
> > 
> > You changed it everywhere but here ...
> 
> call it "st_ino", because that's how fstat calls it?

it's called "st_ino" because it's part of the stat structure.
here, it is not part of the stat structure.