linux-kernel - Re: [PATCH] Input: elantech - add LEN2146 to SMBus blacklist for ThinkPad L13 Gen2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO-hwJJpUj=+mpqQ7eMtbtwX6CPAkt2ZpDnpmX9GUDo1EuEOiw@mail.gmail.com>
Date:   Mon, 8 Feb 2021 09:06:48 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Nikolai Kostrigin <nickel@...linux.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: elantech - add LEN2146 to SMBus blacklist for
 ThinkPad L13 Gen2

Hi Nikolai,

On Mon, Feb 8, 2021 at 9:01 AM Nikolai Kostrigin <nickel@...linux.org> wrote:
>
> ThinkPad L13 Gen2 has both touchpad and trackpoint.
> PNP: LEN2146 PNP0f13
> With the default protocol (elantech-smbus) trackpoint is not operating,
> while touchpad does. Changing to elantech renders both operational.
>
> Signed-off-by: Nikolai Kostrigin <nickel@...linux.org>

Instead of downgrading the capabilities of the touchpad, couldn't we
fix the trackpoint issues?

I am surprised elantech doesn't work with the trackpoint, because I am
pretty sure I wrote patches in that regard. Which kernel version have
you been testing?

Cheers,
Benjamin

> ---
>  drivers/input/mouse/elantech.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index 90f8765f9efc..c4c3fa5828d8 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1776,6 +1776,7 @@ static const char * const i2c_blacklist_pnp_ids[] = {
>          * These are known to not be working properly as bits are missing
>          * in elan_i2c.
>          */
> +       "LEN2146", /* ThinkPad L13 Gen2 */
>         NULL
>  };
>
> --
> 2.29.2
>