linux-kernel - Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208185810.GM20820@kadam>
Date:   Mon, 8 Feb 2021 21:58:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     gregkh@...uxfoundation.org, laurentiu.tudor@....com,
        linux-kernel@...r.kernel.org, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH 1/3] bus: fsl-mc: Fix test for end of loop

On Mon, Feb 08, 2021 at 07:09:47PM +0200, Ioana Ciornei wrote:
> From: Dan Carpenter <dan.carpenter@...cle.com>
> 
> The "desc" pointer can't possibly be NULL here.  If we can't find the
> correct "desc" then tt points to the last element of the
> fsl_mc_accepted_cmds[] array.  Fix this by testing if
> "i == FSL_MC_NUM_ACCEPTED_CMDS" instead.
> 
> Fixes: 2cf1e703f066 ("bus: fsl-mc: add fsl-mc userspace support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Generally the tags are expected to go in chronological order:

Fixes: commit
Signed-off-by: Author
Acked-by: Whoever
Signed-off-by: Maintainer

regards,
dan carpenter