linux-kernel - Re: [PATCH net] vsock: fix locking in vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208111200.467241da@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 8 Feb 2021 11:12:00 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Jorgen Hansen <jhansen@...are.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Andy King <acking@...are.com>, Wei Liu <wei.liu@...nel.org>,
        Dmitry Torokhov <dtor@...are.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        George Zhang <georgezhang@...are.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH net] vsock: fix locking in vsock_shutdown()

On Mon, 8 Feb 2021 16:04:31 +0100 Stefano Garzarella wrote:
> What do you suggest?
> 
> I did it this way because by modifying only the caller, we would have a 
> nested lock.
> 
> This way instead we are sure that if we backport this patch, we don't 
> forget to touch hvs_shutdown() as well.

I'm not a socket expert but the approach seems reasonable to me.