linux-kernel - Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 08 Feb 2021 11:21:21 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jernej Skrabec <jernej.skrabec@...l.net>, mripard@...nel.org,
        wens@...e.org
Cc:     mturquette@...libre.com, airlied@...ux.ie, daniel@...ll.ch,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-sunxi@...glegroups.com, Andre Heider <a.heider@...il.com>
Subject: Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check

Quoting Jernej Skrabec (2021-02-08 04:17:48)
> CLK_SET_RATE_PARENT flag is checked on parent clock instead of current
> one. Fix that.
> 
> Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when allowed")
> Reviewed-by: Chen-Yu Tsai <wens@...e.org>
> Tested-by: Andre Heider <a.heider@...il.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...l.net>
> ---
>  drivers/clk/sunxi-ng/ccu_mp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu_mp.c b/drivers/clk/sunxi-ng/ccu_mp.c
> index fa4ecb915590..5f40be6d2dfd 100644
> --- a/drivers/clk/sunxi-ng/ccu_mp.c
> +++ b/drivers/clk/sunxi-ng/ccu_mp.c
> @@ -108,7 +108,7 @@ static unsigned long ccu_mp_round_rate(struct ccu_mux_internal *mux,
>         max_m = cmp->m.max ?: 1 << cmp->m.width;
>         max_p = cmp->p.max ?: 1 << ((1 << cmp->p.width) - 1);
>  
> -       if (!(clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT)) {
> +       if (!(clk_hw_get_flags(&cmp->common.hw) & CLK_SET_RATE_PARENT)) {

This is also clk_hw_can_set_rate_parent()

>                 ccu_mp_find_best(*parent_rate, rate, max_m, max_p, &m, &p);
>                 rate = *parent_rate / p / m;
>         } else {