linux-kernel - Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing ORC data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABWYdi2hcg6_MYNAWcVPv1aA1NvysXa_w9ghgukc6gTU3a84jw@mail.gmail.com>
Date:   Mon, 8 Feb 2021 12:00:11 -0800
From:   Ivan Babrou <ivan@...udflare.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        kernel-team <kernel-team@...udflare.com>
Subject: Re: [PATCH 2/2] x86/unwind/orc: Silence warnings caused by missing
 ORC data

On Mon, Feb 8, 2021 at 11:56 AM Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>
> On Fri, Feb 05, 2021 at 08:24:03AM -0600, Josh Poimboeuf wrote:
> > The ORC unwinder attempts to fall back to frame pointers when ORC data
> > is missing for a given instruction.  It sets state->error, but then
> > tries to keep going as a best-effort type of thing.  That may result in
> > further warnings if the unwinder gets lost.
> >
> > Until we have some way to register generated code with the unwinder,
> > missing ORC will be expected, and occasionally going off the rails will
> > also be expected.  So don't warn about it.
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
>
> Cc: stable@...r.kernel.org

I was the one who asked for this to be backported, since it solved the
warnings for me.

Tested-by: Ivan Babrou <ivan@...udflare.com>