linux-kernel - Re: [PATCH v1 2/2] ACPI: OSL: Clean up printing messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <337f970b0643d2f67f9a388ff8bbddcf673a1c6b.camel@perches.com>
Date:   Mon, 08 Feb 2021 12:45:31 -0800
From:   Joe Perches <joe@...ches.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux ACPI <linux-acpi@...r.kernel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Hanjun Gou <gouhanjun@...wei.com>
Subject: Re: [PATCH v1 2/2] ACPI: OSL: Clean up printing messages

On Mon, 2021-02-08 at 19:59 +0100, Rafael J. Wysocki wrote:
> Replace the ACPI_DEBUG_PRINT() instance in osl.c unrelated to the
> ACPICA debug with acpi_handle_debug(), add a pr_fmt() definition
> to osl.c and replace direct printk() usage in that file with the
> suitable pr_*() calls.
[]
> ===================================================================
> --- linux-pm.orig/drivers/acpi/osl.c
> +++ linux-pm/drivers/acpi/osl.c
[]
> @@ -528,13 +531,13 @@ acpi_os_predefined_override(const struct
>  
> 
>  	*new_val = NULL;
>  	if (!memcmp(init_val->name, "_OS_", 4) && strlen(acpi_os_name)) {
> -		printk(KERN_INFO PREFIX "Overriding _OS definition to '%s'\n",
> +		pr_info("Overriding _OS definition to '%s'\n",
>  		       acpi_os_name);

If you do more of these, perhaps rewrap lines to 80 columns when possible.

		pr_info("Overriding _OS definition to '%s'\n", acpi_os_name);

etc...