linux-kernel - Re: [patch 00/12] x86/irq/64: Inline irq stack switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202102081346.37FE3A0@keescook>
Date:   Mon, 8 Feb 2021 13:47:30 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>
Subject: Re: [patch 00/12] x86/irq/64: Inline irq stack switching

On Thu, Feb 04, 2021 at 09:49:03PM +0100, Thomas Gleixner wrote:
>   - The fact that the stack switching code ended up being an easy to find
>     exploit gadget.

Thanks for cleaning this up! It looks much much safer now. :)

> The patches have been tested with gcc8, gcc10 and clang-13 (fresh from
> git). The difference between the output of these compilers is minimal.
> gcc8 being slightly worse due to stupid register selection and random
> NOPs injected.

Awesome. Please consider the series:

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook