lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <75573614-2915-54fd-9da1-9d979feaae96@linuxfoundation.org>
Date:   Mon, 8 Feb 2021 16:33:54 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>, shuah@...nel.org
Cc:     tyhicks@...ux.microsoft.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/ipc: remove unneeded semicolon

On 2/8/21 3:24 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/ipc/msgque.c:72:3-4: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:183:2-3: Unneeded semicolon
> ./tools/testing/selftests/ipc/msgque.c:191:2-3: Unneeded semicolon
> 
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   tools/testing/selftests/ipc/msgque.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
> index 5ec4d9e..656c43c 100644
> --- a/tools/testing/selftests/ipc/msgque.c
> +++ b/tools/testing/selftests/ipc/msgque.c
> @@ -69,7 +69,7 @@ int restore_queue(struct msgque_data *msgque)
>   			printf("msgsnd failed (%m)\n");
>   			ret = -errno;
>   			goto destroy;
> -		};
> +		}
>   	}
>   	return 0;
>   
> @@ -180,7 +180,7 @@ int fill_msgque(struct msgque_data *msgque)
>   				IPC_NOWAIT) != 0) {
>   		printf("First message send failed (%m)\n");
>   		return -errno;
> -	};
> +	}
>   
>   	msgbuf.mtype = ANOTHER_MSG_TYPE;
>   	memcpy(msgbuf.mtext, ANOTHER_TEST_STRING, sizeof(ANOTHER_TEST_STRING));
> @@ -188,7 +188,7 @@ int fill_msgque(struct msgque_data *msgque)
>   				IPC_NOWAIT) != 0) {
>   		printf("Second message send failed (%m)\n");
>   		return -errno;
> -	};
> +	}
>   	return 0;
>   }
>   
> 

Thank you. Now applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ