linux-kernel - RE: [RESEND v4 4/6] Documentation: misc-devices: Add Documentation for dw-xdata-pcie driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR12MB18357C5DF57458FD4ECA9E9BDA8F9@DM5PR12MB1835.namprd12.prod.outlook.com>
Date:   Mon, 8 Feb 2021 09:24:49 +0000
From:   Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Arnd Bergmann <arnd@...db.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>
Subject: RE: [RESEND v4 4/6] Documentation: misc-devices: Add Documentation
 for dw-xdata-pcie driver

Hi Krzysztof,

On Sat, Feb 6, 2021 at 23:31:14, Krzysztof Wilczyński <kw@...ux.com> 
wrote:

> Hi Gustavo,
> 
> [...]
> > +The interaction with this driver is done through the module parameter and
> > +can be changed in runtime. The driver outputs the requested command state
> > +information to /var/log/kern.log or dmesg.
> 
> The driver does not seem to offer any parameters (aside of using sysfs
> for runtime settings), and it also seem to only print what it's doing
> when debug level is enabled - unless I am missing something?
> 
> [...]
> > +Request to stop any current TLP transfer:
> > +- Command:
> > +	echo 1 > /sys/kernel/dw-xdata-pcie/stop
> [...]
> 
> When I do the following:
> 
>   # echo 1 > /sys/kernel/dw-xdata-pcie/write
>   # echo 1 > /sys/kernel/dw-xdata-pcie/stop
>   # cat /sys/kernel/dw-xdata-pcie/write
> 
> Would output from cat above simply show "0 MB/s" then?  I wonder how
> someone using this new driver could tell whether "write" or "read"
> traffic generation has been enabled aside of reading the sysfs files,
> would adding "/sys/kernel/dw-xdata-pcie/active" be an overkill here?
> 
> What do you think?

Yes, it would display 0 MB/s. This driver is to be used mainly by the 
Synopsys DesignWare HW prototyping team. I don't think the general public 
will be interested or can use this driver, because requires a special HW 
block available only for this prototype.

I tried to reduce to the minimal the interfaces, to avoid possible 
confusion. For instance, even the /sys/kernel/dw-xdata-pcie/stop 
interface could be avoided, because on the driver unloading or changing 
the between write or read it calls the stop procedure.

Due to the nature of the HW block, it only can allow the write or the 
read at some given moment, therefore based on the last command enable 
write or read, we know which mode is this driving working.
This driver will be used by the testing team on their automation scripts, 
thus they will know exactly the sequence input.

Anyway, thanks for your feedback.

> 
> Krzysztof