linux-kernel - Re: [PATCH 1/2] KVM: selftests: Keep track of memslots more efficiently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208102027.roclkurxiibpx6su@kamzik.brq.redhat.com>
Date:   Mon, 8 Feb 2021 11:20:27 +0100
From:   Andrew Jones <drjones@...hat.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, Shuah Khan <shuah@...nel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Igor Mammedov <imammedo@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] KVM: selftests: Keep track of memslots more
 efficiently

On Mon, Feb 08, 2021 at 11:16:41AM +0100, Andrew Jones wrote:
> > diff --git a/tools/testing/selftests/kvm/lib/rbtree.c b/tools/testing/selftests/kvm/lib/rbtree.c
> > new file mode 100644
> > index 000000000000..a703f0194ea3
> > --- /dev/null
> > +++ b/tools/testing/selftests/kvm/lib/rbtree.c
> > @@ -0,0 +1 @@
> > +#include "../../../../lib/rbtree.c"
> >
> 
> We shouldn't dip into kernel code like this. We can use tools/lib/rbtree.c
> though.
> 
> Besides the rbtree.c thing,

Oops, sorry, just realized the first '..' applies to kvm's lib subdir.
So this is already using tools/lib/rbtree.c

Thanks,
drew

> 
> Reviewed-by: Andrew Jones <drjones@...hat.com>