linux-kernel - Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Feb 2021 08:16:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v1 2/2] mei: bus: change remove callback to return void

Hi "Uwe,

I love your patch! Yet something to improve:

[auto build test ERROR on 5c8fe583cce542aa0b84adc939ce85293de36e5e]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551
base:   5c8fe583cce542aa0b84adc939ce85293de36e5e
config: i386-randconfig-r032-20210208 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a53f4d8c3937ee9db8a6f6335e6d562648f651f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/mei-bus-simplify-mei_cl_device_remove/20210208-062551
        git checkout a53f4d8c3937ee9db8a6f6335e6d562648f651f7
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/misc/mei/hdcp/mei_hdcp.c: In function 'mei_hdcp_remove':
>> drivers/misc/mei/hdcp/mei_hdcp.c:861:1: error: expected ';' before '}' token
     861 | }
         | ^


vim +861 drivers/misc/mei/hdcp/mei_hdcp.c

64e9bbdd9588ad Ramalingam C     2019-02-21  847  
a53f4d8c3937ee Uwe Kleine-König 2021-02-07  848  static void mei_hdcp_remove(struct mei_cl_device *cldev)
64e9bbdd9588ad Ramalingam C     2019-02-21  849  {
fa301ad9fa8f6f Ramalingam C     2019-02-21  850  	struct i915_hdcp_comp_master *comp_master =
fa301ad9fa8f6f Ramalingam C     2019-02-21  851  						mei_cldev_get_drvdata(cldev);
a53f4d8c3937ee Uwe Kleine-König 2021-02-07  852  	int ret;
fa301ad9fa8f6f Ramalingam C     2019-02-21  853  
fa301ad9fa8f6f Ramalingam C     2019-02-21  854  	component_master_del(&cldev->dev, &mei_component_master_ops);
fa301ad9fa8f6f Ramalingam C     2019-02-21  855  	kfree(comp_master);
fa301ad9fa8f6f Ramalingam C     2019-02-21  856  	mei_cldev_set_drvdata(cldev, NULL);
fa301ad9fa8f6f Ramalingam C     2019-02-21  857  
a53f4d8c3937ee Uwe Kleine-König 2021-02-07  858  	ret = mei_cldev_disable(cldev);
a53f4d8c3937ee Uwe Kleine-König 2021-02-07  859  	if (ret)
a53f4d8c3937ee Uwe Kleine-König 2021-02-07  860  		dev_warn(&cldev->dev, "mei_cldev_disable() failed\n")
64e9bbdd9588ad Ramalingam C     2019-02-21 @861  }
64e9bbdd9588ad Ramalingam C     2019-02-21  862  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39276 bytes)