linux-kernel - Re: [PATCH 1/2] mtd: spi-nor: core: Advance erase after the erase cmd has been completed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210208114101.txh7ao7bi66jezrb@ti.com>
Date:   Mon, 8 Feb 2021 17:11:01 +0530
From:   Pratyush Yadav <p.yadav@...com>
To:     Tudor Ambarus <tudor.ambarus@...rochip.com>
CC:     <Takahiro.Kuwano@...ineon.com>, <miquel.raynal@...tlin.com>,
        <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mtd: spi-nor: core: Advance erase after the erase
 cmd has been completed

On 05/02/21 03:52PM, Tudor Ambarus wrote:
> Wait for the erase cmd to complete and then advance the erase.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@...rochip.com>
> ---
>  drivers/mtd/spi-nor/core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 0522304f52fa..bcaa161bc7db 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -1618,12 +1618,12 @@ static int spi_nor_erase_multi_sectors(struct spi_nor *nor, u64 addr, u32 len)
>  			if (ret)
>  				goto destroy_erase_cmd_list;
>  
> -			addr += cmd->size;
> -			cmd->count--;
> -
>  			ret = spi_nor_wait_till_ready(nor);
>  			if (ret)
>  				goto destroy_erase_cmd_list;
> +
> +			addr += cmd->size;
> +			cmd->count--;
>  		}
>  		list_del(&cmd->list);
>  		kfree(cmd);
> @@ -1704,12 +1704,12 @@ static int spi_nor_erase(struct mtd_info *mtd, struct erase_info *instr)
>  			if (ret)
>  				goto erase_err;
>  
> -			addr += mtd->erasesize;
> -			len -= mtd->erasesize;
> -
>  			ret = spi_nor_wait_till_ready(nor);
>  			if (ret)
>  				goto erase_err;
> +
> +			addr += mtd->erasesize;
> +			len -= mtd->erasesize;

Do these changes have any practical benefit? IMO they are worth doing 
even if there is none but I'm curious what prompted this patch.

Reviewed-by: Pratyush Yadav <p.yadav@...com>

>  		}
>  
>  	/* erase multiple sectors */

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.