linux-kernel - Re: [PATCH] Revert "ACPICA: Interpreter: fix memory leak by using existing buffer"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hMJnaHhUYib9d3yQ1CMHLE+Hu3UM4VoN=dOiyriTPmOw@mail.gmail.com>
Date:   Mon, 8 Feb 2021 14:00:58 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Shawn Guo <shawn.guo@...aro.org>, Ard Biesheuvel <ardb@...nel.org>,
        Erik Kaneda <erik.kaneda@...el.com>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        Robert Moore <robert.moore@...el.com>
Subject: Re: [PATCH] Revert "ACPICA: Interpreter: fix memory leak by using
 existing buffer"

On Sat, Feb 6, 2021 at 11:49 AM Shawn Guo <shawn.guo@...aro.org> wrote:
>
> On Sat, Feb 06, 2021 at 09:49:37AM +0100, Ard Biesheuvel wrote:
> > This reverts commit 32cf1a12cad43358e47dac8014379c2f33dfbed4.
> >
> > The 'exisitng buffer' in this case is the firmware provided table, and
> > we should not modify that in place. This fixes a crash on arm64 with
> > initrd table overrides, in which case the DSDT is not mapped with
> > read/write permissions.
> >
> > Cc: Robert Moore <robert.moore@...el.com>
> > Cc: Erik Kaneda <erik.kaneda@...el.com>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> > Cc: Len Brown <lenb@...nel.org>
> > Reported-by: Shawn Guo <shawn.guo@...aro.org>
> > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
>
> Tested-by: Shawn Guo <shawn.guo@...aro.org>

Applied, thanks!

Erik, the upstream will need to sync up with this revert.