linux-kernel - Re: [RFC v4 2/3] vfio/platform: change cleanup order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1925f884-770a-9ec4-018f-02f2c2a881cc@redhat.com>
Date:   Mon, 8 Feb 2021 14:31:44 +0100
From:   Auger Eric <eric.auger@...hat.com>
To:     Vikas Gupta <vikas.gupta@...adcom.com>, alex.williamson@...hat.com,
        cohuck@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     vikram.prakash@...adcom.com, srinath.mannam@...adcom.com,
        ashwin.kamath@...adcom.com, zachary.schroff@...adcom.com,
        manish.kurup@...adcom.com
Subject: Re: [RFC v4 2/3] vfio/platform: change cleanup order

Hi Vikas,

On 1/29/21 6:24 PM, Vikas Gupta wrote:
> In the case of msi, vendor specific msi module may require
> region access to handle msi cleanup so we need to cleanup region
> after irq cleanup only.
> 
> Signed-off-by: Vikas Gupta <vikas.gupta@...adcom.com>
Acked-by: Eric Auger <eric.auger@...hat.com>

Thanks

Eric

> ---
>  drivers/vfio/platform/vfio_platform_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index f2b1f0c3bfcc..1cc040e3ed1f 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -243,8 +243,8 @@ static void vfio_platform_release(void *device_data)
>  			WARN_ON(1);
>  		}
>  		pm_runtime_put(vdev->device);
> -		vfio_platform_regions_cleanup(vdev);
>  		vfio_platform_irq_cleanup(vdev);
> +		vfio_platform_regions_cleanup(vdev);
>  	}
>  
>  	mutex_unlock(&driver_lock);
>