linux-kernel - Re: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the nor-flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210208140943.6dewq4b3dmaxh7ia@kozik-lap>
Date:   Mon, 8 Feb 2021 15:09:43 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     robh@...nel.org, shawnguo@...nel.org, kernel@...gutronix.de,
        festevam@...il.com, kernel@...i.sm, linux-imx@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Angus Ainslie <angus@...ea.ca>
Subject: Re: [PATCH 4/5] arm64: dts: librem5: protect some partitions of the
 nor-flash

On Mon, Feb 08, 2021 at 02:15:26PM +0100, Martin Kepplinger wrote:
> From: Angus Ainslie <angus@...ea.ca>
> 
> These sections should be read only as they contain important data.
> 
> Signed-off-by: Angus Ainslie <angus@...ea.ca>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> ---
>  .../arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index c2bbbdeb93e3..9867e2a50008 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -258,6 +258,22 @@
>  		compatible = "jedec,spi-nor";
>  		reg = <0>;
>  		spi-max-frequency = <1000000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;

One empty line here.

> +		partition@...0000000 {

Wrong unit names. Compile dtses with W=1.

> +			label = "protected0";
> +			reg = <0x00000000 0x00030000>;

Get rid of leading 0000 - it makes it less readable.

Best regards,
Krzysztof