[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210209181259.GF142661@roeck-us.net>
Date: Tue, 9 Feb 2021 10:12:59 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Eddie James <eajames@...ux.ibm.com>
Cc: linux-hwmon@...r.kernel.org, linux-fsi@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, jk@...abs.org, joel@....id.au,
alistair@...ple.id.au, jdelvare@...e.com
Subject: Re: [PATCH 4/4] hwmon: (occ) Print response status in first poll
error message
On Tue, Feb 09, 2021 at 11:12:35AM -0600, Eddie James wrote:
> In order to better debug problems starting up the driver, print
> the response status from the OCC in the error logged when the first
> poll command fails.
>
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
Acked-by: Guenter Roeck <linux@...ck-us.net>
> ---
> drivers/hwmon/occ/common.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c
> index ee0c5d12dfdf..f71d62b57468 100644
> --- a/drivers/hwmon/occ/common.c
> +++ b/drivers/hwmon/occ/common.c
> @@ -1161,8 +1161,9 @@ int occ_setup(struct occ *occ, const char *name)
> dev_info(occ->bus_dev, "host is not ready\n");
> return rc;
> } else if (rc < 0) {
> - dev_err(occ->bus_dev, "failed to get OCC poll response: %d\n",
> - rc);
> + dev_err(occ->bus_dev,
> + "failed to get OCC poll response=%02x: %d\n",
> + occ->resp.return_status, rc);
> return rc;
> }
>
> --
> 2.27.0
>
Powered by blists - more mailing lists