linux-kernel - Re: [PATCH 4.4 22/38] elfcore: fix building with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YCLeJcQFsDIsrAEc@kroah.com>
Date:   Tue, 9 Feb 2021 20:10:29 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Barret Rhoden <brho@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 4.4 22/38] elfcore: fix building with clang

On Tue, Feb 09, 2021 at 02:01:37PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 09, 2021 at 01:52:52PM +0100, Pavel Machek wrote:
> > Hi!
> > 
> > > From: Arnd Bergmann <arnd@...db.de>
> > > 
> > > commit 6e7b64b9dd6d96537d816ea07ec26b7dedd397b9 upstream.
> > > 
> > > kernel/elfcore.c only contains weak symbols, which triggers a bug with
> > > clang in combination with recordmcount:
> > > 
> > >   Cannot find symbol for section 2: .text.
> > >   kernel/elfcore.o: failed
> > > 
> > > Move the empty stubs into linux/elfcore.h as inline functions.  As only
> > > two architectures use these, just use the architecture specific Kconfig
> > > symbols to key off the declaration.
> > 
> > 4.4 has this:
> > 
> > config BINFMT_ELF32
> >         bool
> >         default y if MIPS32_O32 || MIPS32_N32
> >                 select ELFCORE
> > 
> > in arch/mips. So I believe we'll see problems in that
> > configuration...?
> 
> Hm, did I miss a patch to backport?  This is needed to keep 4.4 building
> with newer versions of gcc.  Well, close to building, I'm still haveing
> local issues with 10.2.0 and the 4.4.y tree right now...

Not a gcc issue, looks like a binutils issue on my side...

And the builders seem to have worked ok.

thanks,

greg k-h